Skip to content

fix: use trocador provider icons#1092

Merged
julian-CStack merged 1 commit intocypherstack:stagingfrom
detherminal:staging
Mar 13, 2025
Merged

fix: use trocador provider icons#1092
julian-CStack merged 1 commit intocypherstack:stagingfrom
detherminal:staging

Conversation

@detherminal
Copy link
Contributor

@detherminal detherminal commented Mar 12, 2025

Use Trocador's providers' icons instead of the default Trocador icon, you may also want to add "(via Trocador)" to the provider names. Fetches the logo from the Trocador API's provider_logo key as a url string, fallbacks to default icon if there isn't.

Before:
before

After:
after

@b4n6-b4n6
Copy link

what about Quickex and stealthEx icons? I see the fallback default icon

@detherminal
Copy link
Contributor Author

what about Quickex and stealthEx icons? I see the fallback default icon

The link provided by Trocador is giving 404, that's why they fallback. Not an issue on our side, but Trocador's side.

@b4n6-b4n6
Copy link

b4n6-b4n6 commented Mar 13, 2025

do I understand correctly that all the logos returned by the trocador API are consistently SVGs? In that case I think yes it's reasonable to just accept it like this (we could also hardcode the logos, but that seems silly/wrong approach)

@detherminal
Copy link
Contributor Author

detherminal commented Mar 13, 2025

do I understand correctly that all the logos returned by the trocador API are consistently SVGs? In that case I think yes it's reasonable to just accept it like this (we could also hardcode the logos, but that seems silly/wrong approach)

They are not SVGs but PNGs and the API returns image URLs. Also, hardcoding is not a good idea as providers can change over time and hardcoding creates a technical/practical debt. Reaching to Trocador for them to update the images of 404 giving provider logos can add other providers too.

Copy link
Collaborator

@julian-CStack julian-CStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Hardcoding the images can be done later if trocador's api proves to be really flaky. I believe the network fetch will be fine for now. It also keeps the app bundle smaller (not significantly, but it's something).

@julian-CStack julian-CStack merged commit 7439dbf into cypherstack:staging Mar 13, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants