Skip to content

fix mobile nav issue #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julian-CStack merged 1 commit into from
May 23, 2025
Merged

fix mobile nav issue #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/pages/spark_names/buy_spark_name_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ class _BuySparkNameViewState extends ConsumerState<BuySparkNameView> {
} else {
await Navigator.of(context).pushNamed(
ConfirmSparkNameTransactionView.routeName,
arguments: (txData, widget.walletId),
arguments: (walletId: widget.walletId, txData: txData),
);
}
}
Expand Down
15 changes: 15 additions & 0 deletions lib/route_generator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ import 'pages/settings_views/wallet_settings_view/wallet_settings_wallet_setting
import 'pages/settings_views/wallet_settings_view/wallet_settings_wallet_settings/wallet_settings_wallet_settings_view.dart';
import 'pages/settings_views/wallet_settings_view/wallet_settings_wallet_settings/xpub_view.dart';
import 'pages/spark_names/buy_spark_name_view.dart';
import 'pages/spark_names/confirm_spark_name_transaction_view.dart';
import 'pages/spark_names/spark_names_home_view.dart';
import 'pages/spark_names/sub_widgets/spark_name_details.dart';
import 'pages/special/firo_rescan_recovery_error_dialog.dart';
Expand Down Expand Up @@ -842,6 +843,20 @@ class RouteGenerator {
}
return _routeError("${settings.name} invalid args: ${args.toString()}");

case ConfirmSparkNameTransactionView.routeName:
if (args is ({String walletId, TxData txData})) {
return getRoute(
shouldUseMaterialRoute: useMaterialPageRoute,
builder:
(_) => ConfirmSparkNameTransactionView(
walletId: args.walletId,
txData: args.txData,
),
settings: RouteSettings(name: settings.name),
);
}
return _routeError("${settings.name} invalid args: ${args.toString()}");

case SparkNameDetailsView.routeName:
if (args is ({String walletId, SparkName name})) {
return getRoute(
Expand Down
Loading