feat: add paper wallet functionality#1141
feat: add paper wallet functionality#1141julian-CStack merged 15 commits intocypherstack:paper-wallet-importfrom
Conversation
sneurlax
left a comment
There was a problem hiding this comment.
See notes:
- scanning should respect user's Tor preferences and use Tor if enabled and connected,
- scanning should respect user's node preferences and use preferred nodes other than the default if selected,
- the wallet is swept without confirmation from the user. no txs should be made nor wallets deleted without user confirmation,
- the loading indicator should match the widgets and pattern used elsewhere in the app
lib/pages/add_wallet_views/add_wallet_view/add_wallet_view.dart
Outdated
Show resolved
Hide resolved
|
@sneurlax may have covered some of these points:
|
|
Added a dialog box for both mnemonic display and verify for the new wallet. Fixed other things as Tor, node choice and loading screen. |
julian-CStack
left a comment
There was a problem hiding this comment.
I'm probably missing some things as its been a long day
lib/pages/add_wallet_views/add_wallet_view/add_wallet_view.dart
Outdated
Show resolved
Hide resolved
lib/pages/add_wallet_views/add_wallet_view/add_wallet_view.dart
Outdated
Show resolved
Hide resolved
uses app-wide flushbar refactors scanner as the latest removes unused logging
|
Moved the logic to a standalone function until wallet creation service is implemented. |
|
@julian-CStack @sneurlax Sorry for ping. |
|
While there have been improvements since the opening of this PR, the UX is still not great. The lack of error/failure messages and processing happening without indication in the UI as well as inconsistent mnemonic verification (ui and flow) and wallet creation flow still requires some work. So for now I will merge this into a separate branch until we have time to go over it again. You are welcome to continue working on it and create another PR with changes to https://github.com/cypherstack/stack_wallet/tree/paper-wallet-import |
txidis provided.