Skip to content

fix(macos): close mwebd on app close #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julian-CStack merged 3 commits into from
Jul 30, 2025
Merged

fix(macos): close mwebd on app close #1169

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62c167c
fix(macos): close mwebd on app close
sneurlax Jul 29, 2025
e7737d6
Revert "fix(macos): close mwebd on app close"
sneurlax Jul 30, 2025
99f66cc
fix(macos): shutdown mwebd and force close app on app close request
sneurlax Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import 'dart:async';
import 'dart:io';
import 'dart:math';
import 'dart:ui';

import 'package:coinlib_flutter/coinlib_flutter.dart';
import 'package:compat/compat.dart' as lib_monero_compat;
Expand Down Expand Up @@ -621,6 +622,21 @@ class _MaterialAppWithThemeState extends ConsumerState<MaterialAppWithTheme>
}
}

@override
Future<AppExitResponse> didRequestAppExit() async {
debugPrint("didRequestAppExit called");
if (Platform.isMacOS) {
// On macOS, mwebd fails to shut down, hanging the app on close.
//
// Exiting is a hack fix for this issue.

// await ref.read(pMwebService).shutdown();
// Something like the above would probably be prudent to make.
exit(0);
}
return AppExitResponse.exit;
}

/// should only be called on android currently
Future<void> getOpenFile() async {
// update provider with new file content state
Expand Down
Loading