-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix: filter large user-supplied config values from the cloud API #32957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tgriesser
merged 9 commits into
develop
from
tgriesser/fix/filter-large-user-supplied-values
Nov 19, 2025
Merged
fix: filter large user-supplied config values from the cloud API #32957
tgriesser
merged 9 commits into
develop
from
tgriesser/fix/filter-large-user-supplied-values
Nov 19, 2025
+85
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
tgriesser/fix/filter-large-user-supplied-values
|
| Run status |
|
| Run duration | 18m 56s |
| Commit |
|
| Committer | Tim Griesser |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
12
|
|
|
1098
|
|
|
4
|
|
|
26689
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.48%
|
|
|---|---|
|
|
188
|
|
|
161
|
Accessibility
97.98%
|
|
|---|---|
|
|
4 critical
8 serious
2 moderate
2 minor
|
|
|
101
|
AtofStryker
reviewed
Nov 18, 2025
tgriesser
commented
Nov 18, 2025
AtofStryker
approved these changes
Nov 19, 2025
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Deals with situations where larger than expected config values are coming through to the Cloud APIs inadvertently for certain route paths.
Steps to test
Added test
How has the user experience changed?
Fixes API errors for large serialized webpack configs
PR Tasks
cypress-documentation?type definitions?Note
Filters large/duplicated config values before posting instance tests to Cloud, updating record flow, tests, and changelog.
postInstanceTestsnow sends a filteredconfigusingfilterRuntimeConfigForRecording, removingrawJson/resolved, maskingenvvalues (e.g.,omitted: type), and settingdevServer.{webpackConfig|viteConfig}toomitted.filterRuntimeConfigForRecordingand applies it when constructing request body.filterRuntimeConfigForRecording(config)inpackages/server/lib/config.tsto strip arbitrarily large/duplicated fields from runtime config prior to recording.record.tsto{ ...config, ...runtimeConfig }(removed resolved-origin annotations).env.resolved.*assertions).Written by Cursor Bugbot for commit dd67d03. This will update automatically on new commits. Configure here.