Optimize control char stripping #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of `Regexp.timeout`, which is set to 1s by default in Rails 8.0, we ran into the control char stripping `gsub` sometimes timing out. This can be done much more efficiently with `String#tr_s`, it's about 3x faster and has guaranteed linear performance.
byroot
force-pushed
the
optimize-control-char-stripping
branch
from
1ff72ce to
6901292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of
Regexp.timeout, which is set to 1s by default in Rails 8.0, we ran into the control char strippinggsubsometimes timing out.This can be done much more efficiently with
String#tr_s, it's about 3x faster and has guaranteed linear performance.