Fix max melee calculation to include z-height. #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ability buff was already active
There was one unsquashed bug I discovered during testing last time I played. On sloped surfaces, there's an edge case that can result in being out of range, which has to do with the z-height issue. This patch addresses it by making the check take into account z-height, and also by having the RunTo action take into account z-height as well. I also threw in the model_scale factor, just for good measure though I've never seen it ever be anything other than 1.0, but knowing FFXI, there's an edge case somewhere. Hopefully this squashes the out of range bugs for good. Signed-off-by: Aldros <aldros147@gmail.com>
aldros-ffxi
force-pushed
the
melee_distance_fix
branch
from
f31eb38 to
bb54841
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was one unsquashed bug I discovered during testing last time I played. On sloped surfaces, there's an edge case that can result in being out of range, which has to do with the z-height issue. This patch addresses it by making the check take into account z-height, and also by having the RunTo action take into account z-height as well. I also threw in the model_scale factor, just for good measure though I've never seen it ever be anything other than 1.0, but knowing FFXI, there's an edge case somewhere.
Hopefully this squashes the out of range bugs for good.