Open
Conversation
d-koppenhagen
requested changes
Feb 18, 2022
Owner
d-koppenhagen
left a comment
d-koppenhagen
left a comment
There was a problem hiding this comment.
Good job @croesnick! There is one big thing with the change from shato revision:
I like the change but will will introduce a breaking change.
So existing consumers which already have sha in the comments file have to migrate.
My suggestion:
- provide a migration task, that will convert the file-header into the new format
- once we will merge this features, I will introduce a breaking change in the version so that consumers are aware of the changes (just in case the migration task fails)
Oh and as I merges #124 , a rebase in needed
* Add provider selection to settings (options: git, svn) * Add VCS provider handler which can retrieve git sha as well as svn rev * Rename `sha` to `revision` as more general term in CSV
Also add typescript declarations for stub-spawn-once
croesnick
force-pushed
the
feature/provider-selection
branch
from
6b4c01c to
d93262a
Compare
Owner
|
@croesnick I recently merged some other features/fixes, so a rebase is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, only git repositories are supported.
What is the new behavior?
But in my uses cases, I additionally need svn and also git-svn (as a proxy for svn repos). This PR adds both. It moreover disables all git-related functions (gitlab export and alike) when the provider is not git.
Does this PR introduce a breaking change?
shain CSV has been renamed torevision. I though about deprecating the sha column, but then then new revision column would needed to go to the end of the csv, which IMHO is not ideal. Rationale for just doing the renaming has been that the upgrade path after this change is very easy: simply renameshatorevisionin the csv and we are good to go. In case this is still an inconvenience, we could handle the revision being stored either in therevisionorshaproperty when loading the csv and just not telling the user about it.code-review.gitDirectoryhas been moved tocode-review.vcs.git.directoryOther information