Skip to content

Fix CRLF sequence #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d0iasm merged 1 commit into from
Dec 2, 2024
Merged

Fix CRLF sequence #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion core/src/http.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ pub struct HttpResponse {
/// [ message-body ]
impl HttpResponse {
pub fn new(raw_response: String) -> Result<Self, Error> {
let preprocessed_response = raw_response.trim_start().replace("\n\r", "\n");
let preprocessed_response = raw_response.trim_start().replace("\r\n", "\n");

let (status_line, remaining) = match preprocessed_response.split_once('\n') {
Some((s, r)) => (s, r),
Expand Down Expand Up @@ -162,4 +162,17 @@ mod tests {

assert_eq!(res.body(), "body message".to_string());
}

#[test]
fn test_crlf() {
let raw = "HTTP/1.1 200 OK\r\nDate: xx xx xx\r\n\r\nbody message".to_string();
let res = HttpResponse::new(raw).expect("failed to parse http response");
assert_eq!(res.version(), "HTTP/1.1");
assert_eq!(res.status_code(), 200);
assert_eq!(res.reason(), "OK");

assert_eq!(res.header_value("Date"), Ok("xx xx xx".to_string()));

assert_eq!(res.body(), "body message".to_string());
}
}