Refactor HTML tokenizer to unconditionally set reconsume in two states #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I'd like to keep the current code because it exactly matches the HTML spec. |
Contributor
Author
|
@d0iasm Got it. Thank you for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the HtmlTokenizer to always set self.reconsume = true at the beginning of two states:
In both cases, the flag was previously set conditionally in multiple branches, but always ended up being set regardless of the input.
This change does not affect behavior and serves purely as a cleanup aligned with the structure of the HTML parsing algorithm.