Merged
Conversation
d12frosted
force-pushed
the
fix/compilation-warnings
branch
from
9d5a643 to
4595b25
Compare
- Prefix unused `type` argument with underscore in vui--typed-field-validate - Break long docstring line in vui-typed-field to fit 80 chars - Replace obsolete when-let with when-let* - Add missing (require 'cl-lib) to test file and use cl-oddp
d12frosted
force-pushed
the
fix/compilation-warnings
branch
from
4595b25 to
22793ce
Compare
Work around a byte-compilation issue in Emacs 29 where (plist-get props :type) returns nil unexpectedly when used directly in buttercup expect forms. The workaround is to first extract the value to a let-bound variable.
d12frosted
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(require 'cl-lib)and usecl-oddpinstead ofoddpin testsplist-getresults to variables in buttercup tests to work around an Emacs 29 byte-compilation issue where inline(plist-get props :type)expressions return nil unexpectedly inexpectformsThis fixes the typed-field tests that were failing on Emacs 29.4.