Skip to content

v0.9.0 compliance: full upgrade against core/go reference#3

Open
Snider wants to merge 2 commits intomainfrom
dev
Open

v0.9.0 compliance: full upgrade against core/go reference#3
Snider wants to merge 2 commits intomainfrom
dev

Conversation

@Snider
Copy link
Copy Markdown
Contributor

@Snider Snider commented Apr 28, 2026

Brings this repo to verdict: COMPLIANT.

🤖 Generated with Claude Code + Codex
Co-Authored-By: Codex noreply@openai.com
Co-Authored-By: Virgil virgil@lethean.io

Snider and others added 2 commits April 27, 2026 17:29
@Snider @codex
fix(devops): r2 — replace must* helpers with stdlib + verify CLI modu…
9f6fa7e 
…le resolution on PR #2

Round 2 follow-up to 907c5fa. Closes residual CodeRabbit findings.

Test infra:
- Replaced must* test helpers across cmd_apply_test, cmd_file_sync_test,
  cmd_vm_test, cmd_ci_test, cmd_repo_test, cmd_wizard_test,
  cmd_api_testgen_test, cmd_workflow_test, secret_test, coverage_test,
  scan_secrets_test, snapshot_test with stdlib checks.
- Deleted stale package-level test_helpers_test.go files that only
  supported the old must* pattern.
- AX-6 maintained: no testify Go imports / go.mod requires. Remaining
  go.sum testify entries are transitive checksums after go mod tidy.

Module graph:
- CLI imports switched back to Cobra-compatible
  dappco.re/go/core/cli/pkg/cli module + replacements for private
  vanity modules. GOWORK=off resolves cleanly under isolated cache.
- locales/embed.go / go.sum: i18n checksum + go mod tidy clean.

Verified-but-already-correct (no code change needed):
- cmd/dev/service.go: no-op core.Result{OK:true} + prompt type assertion
- cmd/workspace/config.go: filepath.Abs normalisation + fmt.Errorf
  wrapping
- tests/cli/devops/main.go: raw walk/read errors wrapped
- tests/cli/devops/Taskfile.yaml: strict shell flags
- cmd/dev/cmd_issues.go + cmd_reviews.go: import grouping (after CLI
  module correction)

Verification: gofmt clean, GOWORK=off go vet + go test -count=1 ./...
pass with explicit cache paths.

Closes residual findings on #2

Co-authored-by: Codex <noreply@openai.com>
@Snider @codex
refactor(core): full v0.9.0 compliance against core/go reference
38d4613 
bash /tmp/v090/audit.sh . → verdict: COMPLIANT (all 7 dimensions zero).
go test -count=1 ./... → all green.

Co-authored-by: Codex <noreply@openai.com>
Co-Authored-By: Virgil <virgil@lethean.io>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

Warning

Rate limit exceeded

@Snider has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 7 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a8269fc6-a583-4e40-a824-3d726386a6a6

📥 Commits

Reviewing files that changed from the base of the PR and between 96c953f and 38d4613.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (59)
  • CLAUDE.md
  • cmd/deploy/ax7_test.go
  • cmd/dev/ax7_bundle_test.go
  • cmd/dev/ax7_commands_test.go
  • cmd/dev/cmd_api.go
  • cmd/dev/cmd_api_testgen.go
  • cmd/dev/cmd_api_testgen_test.go
  • cmd/dev/cmd_apply.go
  • cmd/dev/cmd_apply_test.go
  • cmd/dev/cmd_bundles.go
  • cmd/dev/cmd_commit.go
  • cmd/dev/cmd_dev.go
  • cmd/dev/cmd_file_sync.go
  • cmd/dev/cmd_file_sync_test.go
  • cmd/dev/cmd_health.go
  • cmd/dev/cmd_pull.go
  • cmd/dev/cmd_push.go
  • cmd/dev/cmd_vm.go
  • cmd/dev/cmd_vm_test.go
  • cmd/dev/cmd_work.go
  • cmd/dev/cmd_workflow.go
  • cmd/dev/cmd_workflow_test.go
  • cmd/dev/registry.go
  • cmd/dev/service.go
  • cmd/dev/test_helpers_test.go
  • cmd/docs/ax7_test.go
  • cmd/docs/cmd_scan.go
  • cmd/docs/cmd_sync.go
  • cmd/gitcmd/ax7_test.go
  • cmd/gitcmd/cmd_git.go
  • cmd/setup/ax7_commands_test.go
  • cmd/setup/ax7_diff_config_test.go
  • cmd/setup/ax7_github_test.go
  • cmd/setup/cmd_ci.go
  • cmd/setup/cmd_ci_test.go
  • cmd/setup/cmd_registry.go
  • cmd/setup/cmd_repo.go
  • cmd/setup/cmd_repo_test.go
  • cmd/setup/cmd_setup.go
  • cmd/setup/cmd_wizard.go
  • cmd/setup/cmd_wizard_test.go
  • cmd/setup/test_helpers_test.go
  • cmd/workspace/ax7_test.go
  • cmd/workspace/config_test.go
  • deploy/coolify/ax7_test.go
  • deploy/coolify/client.go
  • deploy/python/ax7_test.go
  • deploy/python/python.go
  • devkit/ax7_test.go
  • devkit/coverage_test.go
  • devkit/scan_secrets_test.go
  • devkit/secret_test.go
  • devkit/test_helpers_test.go
  • docs/architecture.md
  • docs/development.md
  • go.mod
  • snapshot/ax7_test.go
  • snapshot/snapshot_test.go
  • snapshot/test_helpers_test.go

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 28, 2026

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Snider