v0.9.0 compliance: full upgrade against core/go reference

[Snider]

Brings this repo to verdict: COMPLIANT against the v0.9.0 audit.

🤖 Generated with Claude Code + Codex
Co-Authored-By: Codex noreply@openai.com
Co-Authored-By: Virgil virgil@lethean.io

Summary by CodeRabbit

• Tests
  • Expanded test coverage for the log package, including validation of close operations, logger state management, error handling, and structured error formatting.

[coderabbitai]

📝 Walkthrough

Walkthrough

Two test files are introduced to validate log package functionality. The first tests nopWriteCloser.Close() method behaviour returning nil across configured, zero-value, and consecutive invocation scenarios. The second provides a comprehensive test suite covering logger contexts, environment-derived username lookup, level stringification, state transitions, structured error handling, and package-level helper functions.

Changes

Cohort / File(s)	Summary
WriteCloser Close Tests tests/cli/log/main_test.go	New test functions validating that nopWriteCloser.Close() returns nil when called on configured instances, zero-value instances, and across multiple consecutive invocations.
AX7 Log Package Test Suite v090_ax7_test.go	Comprehensive test suite validating log package AX7 behaviour including logger contexts with buffer writes, environment-derived username handling, level stringification with normalization, logger state transitions, message escaping, structured error formatting and unwrapping, retryability detection, recovery metadata propagation, error inspection helpers, and package-level helper function behaviour.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly addresses the main objective: achieving v0.9.0 compliance through a comprehensive upgrade, which aligns with the added test files validating AX7 behaviour and log package functionality.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@v090_ax7_test.go`:
- Around line 13-21: The declared type ax7RotationWriter and its method
(*ax7RotationWriter).Close are unused and trigger lint errors; remove the
ax7RotationWriter type and its Close method from the test file (or alternatively
wire it into the test where an io.Writer/io.Closer is required by replacing the
writer usage with an instance of ax7RotationWriter) so that neither the type nor
Close remain declared but unused.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e426d1c9-106f-4d4e-b8df-af23ae415308

📥 Commits

Reviewing files that changed from the base of the PR and between fbd206f and df05298.

📒 Files selected for processing (2)

• tests/cli/log/main_test.go
• v090_ax7_test.go

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Remove or wire in ax7RotationWriter; it currently fails lint checks.

ax7RotationWriter and (*ax7RotationWriter).Close are declared but never used, and unused reports both as errors.

Suggested fix

-type ax7RotationWriter struct {
-	io.Writer
-	closed bool
-}
-
-func (w *ax7RotationWriter) Close() error {
-	w.closed = true
-	return nil
-}

As per coding guidelines: **/*.go: Use core go lint for linting.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	type ax7RotationWriter struct {
	io.Writer
	closed bool
	}
	func (w *ax7RotationWriter) Close() error {
	w.closed = true
	return nil
	}

🧰 Tools

🪛 golangci-lint (2.11.4)

[error] 13-13: type ax7RotationWriter is unused

(unused)

---

[error] 18-18: func (*ax7RotationWriter).Close is unused

(unused)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@v090_ax7_test.go` around lines 13 - 21, The declared type ax7RotationWriter
and its method (*ax7RotationWriter).Close are unused and trigger lint errors;
remove the ax7RotationWriter type and its Close method from the test file (or
alternatively wire it into the test where an io.Writer/io.Closer is required by
replacing the writer usage with an instance of ax7RotationWriter) so that
neither the type nor Close remain declared but unused.