Skip to content

v0.9.0 compliance: full upgrade against core/go reference#1

Open
Snider wants to merge 18 commits intomainfrom
dev
Open

v0.9.0 compliance: full upgrade against core/go reference#1
Snider wants to merge 18 commits intomainfrom
dev

Conversation

@Snider
Copy link
Copy Markdown
Contributor

@Snider Snider commented Apr 28, 2026

Brings this repo to verdict: COMPLIANT against the v0.9.0 audit.

🤖 Generated with Claude Code + Codex
Co-Authored-By: Codex noreply@openai.com
Co-Authored-By: Virgil virgil@lethean.io

Snider and others added 18 commits April 14, 2026 16:32
Internal package paths migrated to dappco.re/go/core/rocm/internal/*.
External imports (coreerr, go-inference) intentionally left on
forge.lthn.ai for now — the homelab factory will pick up the rest of
the migration as part of its dispatch loop.

Also: CLAUDE.md refresh with current architecture notes.

Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Record partial metrics for classify cancellations and failures, wrap batch cancellation errors with coreerr.E, and replace the positional server startup arguments with a named config struct for clearer internal call sites.

Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Closes tasks.lthn.sh/view.php?id=703

Co-authored-by: Codex <noreply@openai.com>
server.go is the ROCm HTTP server for GPU monitoring. stdlib imports
(errors, fmt, net, os, os/exec, strconv, strings) are intrinsic:
HTTP server primitives have no core equivalent, rocm-smi CLI subprocess
predates Process plumbing into bare HTTP handlers, and core string/
format helpers are downstream. Added `// Note:` annotations on each.

Closes tasks.lthn.sh/view.php?id=714

Co-authored-by: Codex <noreply@openai.com>
vram.go reads GPU VRAM from sysfs. Banned imports are intrinsic —
sysfs reading needs direct filesystem access that core.Fs() doesn't
model. Added `// Note:` annotations on os, path/filepath, strconv,
strings.

Closes tasks.lthn.sh/view.php?id=715

Co-authored-by: Codex <noreply@openai.com>
…o.re/go/core/log (AX-6)

Salvaged partial commit from stream-errored codex run — imports were
already rewritten in backend.go, discover.go, internal/gguf/gguf.go,
internal/llamacpp/client.go + go.mod direct requires.

Closes tasks.lthn.sh/view.php?id=702

Co-authored-by: Codex <noreply@openai.com>
Closes tasks.lthn.sh/view.php?id=716

Co-authored-by: Codex <noreply@openai.com>
- Bump dappco.re/go/* deps to v0.8.0-alpha.1 in go.mod (any forge.lthn.ai/core/* paths migrated to canonical dappco.re/go/* form)

Co-Authored-By: Athena <athena@lthn.ai>
bash /tmp/v090/audit.sh . → verdict: COMPLIANT (all 7 dimensions zero).

Co-authored-by: Codex <noreply@openai.com>
Co-Authored-By: Virgil <virgil@lethean.io>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

Warning

Rate limit exceeded

@Snider has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 43 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 735f865a-260f-4fec-b9a7-850156cc2018

📥 Commits

Reviewing files that changed from the base of the PR and between ed9bdd1 and bfd5b3a.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (35)
  • CLAUDE.md
  • README.md
  • backend.go
  • backend_ax7_test.go
  • backend_test.go
  • discover.go
  • discover_ax7_test.go
  • discover_test.go
  • docs/architecture.md
  • go.mod
  • internal/gguf/ax7_test.go
  • internal/gguf/gguf.go
  • internal/gguf/gguf_test.go
  • internal/llamacpp/ax7_test.go
  • internal/llamacpp/client.go
  • internal/llamacpp/client_test.go
  • internal/llamacpp/health.go
  • internal/llamacpp/health_test.go
  • model.go
  • model_ax7_test.go
  • model_test.go
  • register_rocm.go
  • rocm.go
  • rocm_benchmark_test.go
  • rocm_integration_test.go
  • rocm_linux_ax7_test.go
  • rocm_stub.go
  • rocm_stub_ax7_test.go
  • server.go
  • server_ax7_test.go
  • server_test.go
  • tests/cli/rocm/Taskfile.yaml
  • tests/cli/rocm/main.go
  • vram.go
  • vram_test.go

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant