Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions analytics.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
package session

import (
"maps"
"slices"
"time"
"maps" // Note: intrinsic — maps.Keys exposes tool names for deterministic analytics output; no core equivalent
"slices" // Note: intrinsic — slices.Sorted orders analytics rows deterministically; no core equivalent
"time" // Note: intrinsic — time.Duration arithmetic for session, active-time, and latency metrics; no core equivalent

core "dappco.re/go/core"
)
Expand Down
101 changes: 49 additions & 52 deletions analytics_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ package session
import (
"testing"
"time"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

func TestAnalytics_AnalyseEmptySession_Good(t *testing.T) {
Expand All @@ -18,22 +15,22 @@ func TestAnalytics_AnalyseEmptySession_Good(t *testing.T) {
}

a := Analyse(sess)
require.NotNil(t, a)
requireNotNil(t, a)

assert.Equal(t, time.Duration(0), a.Duration)
assert.Equal(t, time.Duration(0), a.ActiveTime)
assert.Equal(t, 0, a.EventCount)
assert.Equal(t, 0.0, a.SuccessRate)
assert.Empty(t, a.ToolCounts)
assert.Empty(t, a.ErrorCounts)
assert.Equal(t, 0, a.EstimatedInputTokens)
assert.Equal(t, 0, a.EstimatedOutputTokens)
assertEqual(t, time.Duration(0), a.Duration)
assertEqual(t, time.Duration(0), a.ActiveTime)
assertEqual(t, 0, a.EventCount)
assertEqual(t, 0.0, a.SuccessRate)
assertEmpty(t, a.ToolCounts)
assertEmpty(t, a.ErrorCounts)
assertEqual(t, 0, a.EstimatedInputTokens)
assertEqual(t, 0, a.EstimatedOutputTokens)
}

func TestAnalytics_AnalyseNilSession_Good(t *testing.T) {
a := Analyse(nil)
require.NotNil(t, a)
assert.Equal(t, 0, a.EventCount)
requireNotNil(t, a)
assertEqual(t, 0, a.EventCount)
}

func TestAnalytics_AnalyseSingleToolCall_Good(t *testing.T) {
Expand All @@ -56,14 +53,14 @@ func TestAnalytics_AnalyseSingleToolCall_Good(t *testing.T) {

a := Analyse(sess)

assert.Equal(t, 5*time.Second, a.Duration)
assert.Equal(t, 2*time.Second, a.ActiveTime)
assert.Equal(t, 1, a.EventCount)
assert.Equal(t, 1.0, a.SuccessRate)
assert.Equal(t, 1, a.ToolCounts["Bash"])
assert.Equal(t, 0, a.ErrorCounts["Bash"])
assert.Equal(t, 2*time.Second, a.AvgLatency["Bash"])
assert.Equal(t, 2*time.Second, a.MaxLatency["Bash"])
assertEqual(t, 5*time.Second, a.Duration)
assertEqual(t, 2*time.Second, a.ActiveTime)
assertEqual(t, 1, a.EventCount)
assertEqual(t, 1.0, a.SuccessRate)
assertEqual(t, 1, a.ToolCounts["Bash"])
assertEqual(t, 0, a.ErrorCounts["Bash"])
assertEqual(t, 2*time.Second, a.AvgLatency["Bash"])
assertEqual(t, 2*time.Second, a.MaxLatency["Bash"])
}

func TestAnalytics_AnalyseMixedToolsWithErrors_Good(t *testing.T) {
Expand Down Expand Up @@ -127,24 +124,24 @@ func TestAnalytics_AnalyseMixedToolsWithErrors_Good(t *testing.T) {

a := Analyse(sess)

assert.Equal(t, 5*time.Minute, a.Duration)
assert.Equal(t, 7, a.EventCount)
assertEqual(t, 5*time.Minute, a.Duration)
assertEqual(t, 7, a.EventCount)

// Tool counts
assert.Equal(t, 2, a.ToolCounts["Bash"])
assert.Equal(t, 2, a.ToolCounts["Read"])
assert.Equal(t, 1, a.ToolCounts["Edit"])
assertEqual(t, 2, a.ToolCounts["Bash"])
assertEqual(t, 2, a.ToolCounts["Read"])
assertEqual(t, 1, a.ToolCounts["Edit"])

// Error counts
assert.Equal(t, 1, a.ErrorCounts["Bash"])
assert.Equal(t, 1, a.ErrorCounts["Read"])
assert.Equal(t, 0, a.ErrorCounts["Edit"])
assertEqual(t, 1, a.ErrorCounts["Bash"])
assertEqual(t, 1, a.ErrorCounts["Read"])
assertEqual(t, 0, a.ErrorCounts["Edit"])

// Success rate: 3 successes out of 5 tool calls = 0.6
assert.InDelta(t, 0.6, a.SuccessRate, 0.001)
assertInDelta(t, 0.6, a.SuccessRate, 0.001)

// Active time: 1s + 500ms + 200ms + 100ms + 300ms = 2.1s
assert.Equal(t, 2100*time.Millisecond, a.ActiveTime)
assertEqual(t, 2100*time.Millisecond, a.ActiveTime)
}

func TestAnalytics_AnalyseLatencyCalculations_Good(t *testing.T) {
Expand Down Expand Up @@ -183,12 +180,12 @@ func TestAnalytics_AnalyseLatencyCalculations_Good(t *testing.T) {
a := Analyse(sess)

// Bash: avg = (1+3+5)/3 = 3s, max = 5s
assert.Equal(t, 3*time.Second, a.AvgLatency["Bash"])
assert.Equal(t, 5*time.Second, a.MaxLatency["Bash"])
assertEqual(t, 3*time.Second, a.AvgLatency["Bash"])
assertEqual(t, 5*time.Second, a.MaxLatency["Bash"])

// Read: avg = 200ms, max = 200ms
assert.Equal(t, 200*time.Millisecond, a.AvgLatency["Read"])
assert.Equal(t, 200*time.Millisecond, a.MaxLatency["Read"])
assertEqual(t, 200*time.Millisecond, a.AvgLatency["Read"])
assertEqual(t, 200*time.Millisecond, a.MaxLatency["Read"])
}

func TestAnalytics_AnalyseTokenEstimation_Good(t *testing.T) {
Expand Down Expand Up @@ -220,9 +217,9 @@ func TestAnalytics_AnalyseTokenEstimation_Good(t *testing.T) {
a := Analyse(sess)

// Input tokens: 400/4 + 80/4 + 120/4 = 100 + 20 + 30 = 150
assert.Equal(t, 150, a.EstimatedInputTokens)
assertEqual(t, 150, a.EstimatedInputTokens)
// Output tokens: 0 + 200/4 + 0 = 50
assert.Equal(t, 50, a.EstimatedOutputTokens)
assertEqual(t, 50, a.EstimatedOutputTokens)
}

func TestAnalytics_FormatAnalyticsOutput_Good(t *testing.T) {
Expand Down Expand Up @@ -255,17 +252,17 @@ func TestAnalytics_FormatAnalyticsOutput_Good(t *testing.T) {

output := FormatAnalytics(a)

assert.Contains(t, output, "Session Analytics")
assert.Contains(t, output, "5m0s")
assert.Contains(t, output, "2m0s")
assert.Contains(t, output, "42")
assert.Contains(t, output, "85.0%")
assert.Contains(t, output, "1500")
assert.Contains(t, output, "3000")
assert.Contains(t, output, "Bash")
assert.Contains(t, output, "Read")
assert.Contains(t, output, "Edit")
assert.Contains(t, output, "Tool Breakdown")
assertContains(t, output, "Session Analytics")
assertContains(t, output, "5m0s")
assertContains(t, output, "2m0s")
assertContains(t, output, "42")
assertContains(t, output, "85.0%")
assertContains(t, output, "1500")
assertContains(t, output, "3000")
assertContains(t, output, "Bash")
assertContains(t, output, "Read")
assertContains(t, output, "Edit")
assertContains(t, output, "Tool Breakdown")
}

func TestAnalytics_FormatAnalyticsEmptyAnalytics_Good(t *testing.T) {
Expand All @@ -278,8 +275,8 @@ func TestAnalytics_FormatAnalyticsEmptyAnalytics_Good(t *testing.T) {

output := FormatAnalytics(a)

assert.Contains(t, output, "Session Analytics")
assert.Contains(t, output, "0.0%")
assertContains(t, output, "Session Analytics")
assertContains(t, output, "0.0%")
// No tool breakdown section when no tools
assert.NotContains(t, output, "Tool Breakdown")
assertNotContains(t, output, "Tool Breakdown")
}
2 changes: 1 addition & 1 deletion conventions_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func TestConventions_BannedImports_Good(t *testing.T) {
for _, spec := range file.ast.Imports {
importPath := trimQuotes(spec.Path.Value)
if core.HasPrefix(importPath, "forge.lthn.ai/") {
t.Errorf("%s imports %q; use dappco.re/go/core/... paths instead", file.path, importPath)
t.Errorf("%s imports %q; use dappco.re/go/... paths instead", file.path, importPath)
continue
}
if reason, ok := banned[importPath]; ok {
Expand Down
2 changes: 1 addition & 1 deletion core_helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
package session

import (
"bytes"
"bytes" // Note: intrinsic — byte-slice helpers implement local string primitives without strings import; no core equivalent

core "dappco.re/go/core"
)
Expand Down
14 changes: 2 additions & 12 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,15 +1,5 @@
module dappco.re/go/core/session
module dappco.re/go/session

go 1.26.0

require (
dappco.re/go/core v0.8.0-alpha.1
github.com/stretchr/testify v1.11.1
)

require (
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
github.com/kr/text v0.2.0 // indirect
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
)
require dappco.re/go/core v0.8.0-alpha.1
12 changes: 0 additions & 12 deletions go.sum
Original file line number Diff line number Diff line change
@@ -1,20 +1,8 @@
dappco.re/go/core v0.8.0-alpha.1 h1:gj7+Scv+L63Z7wMxbJYHhaRFkHJo2u4MMPuUSv/Dhtk=
dappco.re/go/core v0.8.0-alpha.1/go.mod h1:f2/tBZ3+3IqDrg2F5F598llv0nmb/4gJVCFzM5geE4A=
github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc h1:U9qPSI2PIWSS1VwoXQT9A3Wy9MM3WgvqSxFWenqJduM=
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 h1:Jamvg5psRIccs7FGNTlIRMkT8wgtp5eCXdBlqhYGL6U=
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/rogpeppe/go-internal v1.14.1 h1:UQB4HGPB6osV0SQTLymcB4TgvyWu6ZyliaW0tI/otEQ=
github.com/rogpeppe/go-internal v1.14.1/go.mod h1:MaRKkUm5W0goXpeCfT7UZI6fk/L7L7so1lCWt35ZSgc=
github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu7U=
github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk=
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c/go.mod h1:JHkPIbrfpd72SG/EVd6muEfDQjcINNoR0C8j2r3qZ4Q=
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
6 changes: 3 additions & 3 deletions html.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
package session

import (
"html"
"path"
"time"
"html" // Note: intrinsic — escaping transcript content for generated HTML; stdlib encoder is the output contract
"path" // Note: intrinsic — output parent directory derivation for slash-separated paths; no core equivalent
"time" // Note: intrinsic — duration formatting thresholds for rendered summaries; no core equivalent

core "dappco.re/go/core"
)
Expand Down
Loading