Fragment for Supported devices white variant.#242
Open
RitwikSrivastava wants to merge 3 commits intomainfrom
Open
Fragment for Supported devices white variant.#242RitwikSrivastava wants to merge 3 commits intomainfrom
RitwikSrivastava wants to merge 3 commits intomainfrom
Conversation
|
RitwikSrivastava
commented
Jul 7, 2025
| } | ||
|
|
||
| .section.white.supported-devices span.icon img{ | ||
| filter: invert(0) brightness(0); |
Collaborator
Author
There was a problem hiding this comment.
Instead of using new svgs (for white variant ) used filter to get the svg for white background.
RitwikSrivastava
changed the title
RitwikSrivastava
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Please ensure you have selected
da-pilot/slingas the base repository when creating this pull request.Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #238
Test URLs:
old dark one- https://issue238--sling--da-pilot.aem.page/drafts/ritwik/dark-supported-devices