Rewrite cld to actually be async with a promise API#62
Merged
dachev merged 2 commits intodachev:masterfrom May 6, 2020
Merged
Conversation
implausible
force-pushed
the
feature/actually-async
branch
from
de058a7 to
d9e55be
Compare
Owner
|
@implausible this is looking great! Would you mind updating the README to emphasize modern syntax? I would change the Simple and Advanced examples and add a new section Legacy with a callback example. |
Contributor
Author
|
@dachev Sure can. I have updated the documentation. Let me know if you have any additional requests! |
Owner
|
Beautiful! Thank you @implausible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like it might be beneficial for electron-spellchecker for this library to have a true async API. See electron-userland/electron-spellchecker#170.
Since we were already using the node callback pattern, most users have been promisifying this call anyway. I've preserved the callback API so that it should not be a breaking change (unless someone depended on the implementation actually being synchronous).