forked from chris0chris/league-manager
-
Notifications
You must be signed in to change notification settings - Fork 1
style(designer): Gameday Designer UI/UX Polish #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #729 +/- ##
==========================================
- Coverage 84.99% 84.63% -0.37%
==========================================
Files 114 116 +2
Lines 3879 3898 +19
Branches 805 806 +1
==========================================
+ Hits 3297 3299 +2
- Misses 398 412 +14
- Partials 184 187 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHASE 4 COMPLETION: Gameday Designer UI/UX Polish
Overview
This phase focused on standardizing the Gameday Designer's list-based UI, improving visual consistency, and implementing responsive layout behaviors.
Key Changes
1. Unified Action Button Pattern
outline-dangericon-only buttons that never expand on hover, preventing accidental layout shifts or misclicks during rapid deletion.2. Iconography & Visual Style
STAGE:bi-layersFOLDER:bi-collectionDELETE:bi-trash3TOURNAMENT:bi-trophyme-2class to all icons when labels are visible.3. Responsive Layout & Accessibility
fields-gridusing CSS Grid, restricted to a maximum of 2 columns on wide screens (min-width: 900px).titleattributes, fully translated in English and German.strategy: 'fixed'to the Team Pool "Move to group" dropdown and the Status Bar validation popovers to prevent clipping by parent container boundaries.4. Notification System
alert()calls with a modern, non-blocking Toast notification system (NotificationToast.tsx) positioned at the bottom-right of the viewport.Technical Improvements
FieldSection,StageSection,GameTable, andTeamGroupCardto use common UI patterns.FlowToolbar.test.tsx,GlobalTeamTable.test.tsx,FieldSection.test.tsx,StageSection.test.tsx) to match the new accessible titles and button behaviors.useDesignerController.Verification Status