Skip to content

Conversation

@HJK181
Copy link
Contributor

@HJK181 HJK181 commented Aug 6, 2020

Started a new branch as without testcontainers changes. Also addressed requested changes from #118
#118 can be closed.

Copy link
Owner

@dadoonet dadoonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's very good and we could merge it soon.
Some few requests:

  • Could you use spaces instead of tabs? (Yeah I know...)
  • Could you add the following header in the new java files you added?
/*
 * Licensed to David Pilato (the "Author") under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership. Author licenses this
 * file to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 *    http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing,
 * software distributed under the License is distributed on an
 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 * KIND, either express or implied.  See the License for the
 * specific language governing permissions and limitations
 * under the License.
 */

@dadoonet dadoonet added the new label Oct 20, 2020
@dadoonet dadoonet added this to the 7.x milestone Oct 20, 2020
@dadoonet dadoonet self-assigned this Oct 20, 2020
@viqtor
Copy link
Contributor

viqtor commented May 31, 2021

@dadoonet @HJK181 would CommerceExperts#1 help drive this along? or would you like it targeted towards the main repo?

@dadoonet
Copy link
Owner

I believe that if you send your PR to this repo that'd be easier to merge. 😁

Thanks !

@viqtor
Copy link
Contributor

viqtor commented May 31, 2021

I believe that if you send your PR to this repo that'd be easier to merge. 😁

Thanks !

sure thing. git-fu not on top today so ended up with #160 wanted to avoid taking credit for @HJK181 works is all

@dadoonet
Copy link
Owner

Closing in favor of #160. Thank a lot @HJK181 for the great work on this!

@dadoonet dadoonet closed this May 31, 2021
@dadoonet dadoonet removed this from the 7.x milestone May 31, 2021
@dadoonet dadoonet removed the new label May 31, 2021
@HJK181
Copy link
Contributor Author

HJK181 commented May 31, 2021

Thank you @viqtor for taking this over, I lost track of it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants