Skip to content

Comments

Chore | Refactor to use unstructured.Unstructured instead of raw YAML strings#352

Merged
dag-andersen merged 2 commits intomainfrom
refactor-when-string-to-yaml-is-happening
Feb 21, 2026
Merged

Chore | Refactor to use unstructured.Unstructured instead of raw YAML strings#352
dag-andersen merged 2 commits intomainfrom
refactor-when-string-to-yaml-is-happening

Conversation

@dag-andersen
Copy link
Owner

Summary

  • GetManifests and AppsetGenerate now return []unstructured.Unstructured instead of raw YAML strings
  • YAML/JSON parsing moved into the CLI and API operation layers instead of happening later in the pipeline
  • Replaced string-based ReplaceAll for app ID substitution with a recursive object traversal (replaceAppIdInManifests)
  • Moved and renamed processYamlOutputparseYAMLManifests (now in pkg/argocd/call_cli.go)
  • Added replaceAppIdInManifests utility with tests in pkg/extract/utils.go

@dag-andersen dag-andersen merged commit e2ccd50 into main Feb 21, 2026
3 checks passed
@dag-andersen dag-andersen deleted the refactor-when-string-to-yaml-is-happening branch February 21, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant