Skip to content

Conversation

@kaapstorm
Copy link
Collaborator

@bradleyayers @dag I am not sure who to notify on this pull request.

Recently I recalled Attest, the one Python testing library that does testing right, by using idiomatic Python, and without magical fixtures. I last checked on it a while ago, and it looked dormant, and I sadly went back to pytest. But this weekend I thought I'd ask Claude to help me to migrate it to Python 3.11. This is the result.

There is more to do, but I thought I'd pause, open a pull request, and use it as an opportunity to ask you some questions:

  1. Are either of you the right people to be asking these questions? Should someone else be notified of this pull request? Or is Attest dead, and I should quietly walk away?
  2. Is this pull request welcome?
  3. Do you want more detail in the commit messages?
  4. attest/deprecated.py imports lxml, but it is not listed as a dependency. Should it be?
  5. I started linting, and then decided to hold off on that for now. Do you have opinions on what to change and what to leave?
  6. And of course, what in this pull request do you think I should change?

@dag
Copy link
Owner

dag commented Nov 5, 2025

I don't think anyone is actively working on Attest anymore. I'd be happy to add you to the GitHub and PyPI if you want to work on it?

@kaapstorm
Copy link
Collaborator Author

That would be cool! If my email address would help, it's "norman at kaapstorm dot com".

@dag dag mentioned this pull request Nov 15, 2025
3 tasks
@dag
Copy link
Owner

dag commented Nov 15, 2025

That would be cool! If my email address would help, it's "norman at kaapstorm dot com".

I've added you to the GitHub, but (as you can see above) I'm currently locked out of PyPI and they say "There may be a delay of a week or more between responses for these issues."

@dag
Copy link
Owner

dag commented Dec 20, 2025

@kaapstorm What's your PyPI username?

@kaapstorm
Copy link
Collaborator Author

Hi @dag It's "kaapstorm".

@dag
Copy link
Owner

dag commented Jan 15, 2026

kaapstorm

I've sent you an invite now. Sorry it took so long!

@kaapstorm
Copy link
Collaborator Author

No problem, I've been really busy too, and thank you!

I have one burning question: What do you think should happen to attest/deprecated.py? I'm happy to discuss here, or over email. I'm also happy to figure things out by myself. :)

@dag
Copy link
Owner

dag commented Jan 16, 2026

I have one burning question: What do you think should happen to attest/deprecated.py? I'm happy to discuss here, or over email. I'm also happy to figure things out by myself. :)

I think:

  1. I don't fully remember XD
  2. The deprecated APIs seem to be an attempt at a Pythonic API for assertions pre-assert-hook. I think I just thought self.assertBool(); self.assertEq() felt "ugh" and assert_() and Assert() were easier starting points than writing the assert hook which has to parse and generate Python code. lxml was treated as a "soft" dependency in case you wanted to use the xpath and css helpers, I guess? And given the note in the docstring, perhaps to make Attest work on pypy.
  3. It's technically been deprecated for ~14 years; if you prefer the assert_hook — or want to try something entirely different — have at it. I sort of doubt people are depending on Attest today, so I say: do what you want with it. :)

BTW, I also created http://github.com/dag/detest during intense hyperfocus flow one sleep-deprived night. I remember it as being "inspired" and much better than Attest, although it's also entirely undocumented and unused, other than its own test suite.

@kaapstorm
Copy link
Collaborator Author

Thank you.

felt "ugh"

Yes!

if you prefer the assert_hook

I do.

http://github.com/dag/detest

Ooo, that looks really interesting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants