Merged
Conversation
…em in the cors handler
… a global variable
daido1976
commented
Jan 21, 2025
| var rootHandler http.Handler | ||
|
|
||
| if enableCors == "true" { | ||
| rootHandler = cors.AllowAll().Handler(http.HandlerFunc(lambdaUrlProxyHandler)) |
Owner
Author
There was a problem hiding this comment.
At first I tried to use cors.Default(), but it does not allow PUT/DELETE method, etc.
daido1976
commented
Jan 21, 2025
Comment on lines
+10
to
+11
| # Uncomment out when testing for CORS. | ||
| # ENABLE_CORS: "true" |
Owner
Author
There was a problem hiding this comment.
I have not written any tests, only operation checks, so I would like to write tests once the specifications are finalized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Issue: #1
Inspired by LocalStack, I considered supporting environment variables like
CORS_ALLOWED_ORIGINS,CORS_ALLOWED_HEADERS, andCORS_ALLOWED_METHODS. However, since this is a tool for local development, I wasn’t sure if such detailed configurations were necessary. For now, I decided to support only theENABLE_CORSenvironment variable.The implementation is minimal, setting
Access-Control-Allow-Origin: *. This does not allow credentials like cookies to be sent across origins. However, the current implementation does not support cookies at all, so this should not be an issue.If additional issues are raised, I will consider supporting more detailed configurations.
Note
Operation Check
Check the operation with
ENABLE_CORS: truein the test directory.