Open
Conversation
dailymp
requested changes
Apr 6, 2020
Owner
dailymp
left a comment
dailymp
left a comment
There was a problem hiding this comment.
Please review comments and try to fix the work related.
Comment on lines
+1
to
+9
| import React from 'react'; | ||
| import { render } from '@testing-library/react'; | ||
| import App from './App'; | ||
|
|
||
| test('renders learn react link', () => { | ||
| const { getByText } = render(<App />); | ||
| const linkElement = getByText(/learn react/i); | ||
| expect(linkElement).toBeInTheDocument(); | ||
| }); |
| //https://store-webapi.herokuapp.com/swagger-ui.html#/produto-controller | ||
|
|
||
| const url = 'https://store-webapi.herokuapp.com/api/produto'; | ||
|
|
Owner
There was a problem hiding this comment.
Could you define a file to isolate all api urls?
|
|
||
| export const getAPI = () => { | ||
| return new Promise(resolve => { | ||
| fetch(url) |
Owner
There was a problem hiding this comment.
Can you use axios as alternative to fetch?
| <Row> | ||
|
|
||
| <Col md="6"> | ||
| <Form.Group controlId="descricao"> |
Owner
There was a problem hiding this comment.
We used to program all in english, can you adjust to that?
| } | ||
| } | ||
|
|
||
| export default connect(null, mapDispatchToProps)(ModalAdd); No newline at end of file |
Owner
There was a problem hiding this comment.
We avoid export default, can you refactor the export defaults one?
Comment on lines
+1
to
+3
| // This optional code is used to register a service worker. | ||
| // register() is not called by default. | ||
|
|
Comment on lines
+1
to
+5
| // jest-dom adds custom jest matchers for asserting on DOM nodes. | ||
| // allows you to do things like: | ||
| // expect(element).toHaveTextContent(/react/i) | ||
| // learn more: https://github.com/testing-library/jest-dom | ||
| import '@testing-library/jest-dom/extend-expect'; |
Owner
There was a problem hiding this comment.
I can see there is only one test and it is failing, we need at least 75% of coverage
Comment on lines
+1
to
+8
| This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). | ||
|
|
||
| ## Available Scripts | ||
|
|
||
| In the project directory, you can run: | ||
|
|
||
| ### `npm start` | ||
|
|
Owner
There was a problem hiding this comment.
Add a good readme related to your work
Comment on lines
+1
to
+6
| .App { | ||
| text-align: center; | ||
| } | ||
|
|
||
| .App-logo { | ||
| height: 40vmin; |
Comment on lines
+1
to
+7
| import React from 'react'; | ||
| import './App.css'; | ||
| import User from './components/User'; | ||
| import { useSelector } from "react-redux"; | ||
| import Table from './components/Table'; | ||
|
|
||
| export default function App() { |
Owner
There was a problem hiding this comment.
We use typescript, can you use it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.