Add weights and biases support#348
Conversation
|
I can't comprehend why isort is throwing an error here, I tried changing the import order in the faulty file several times and it always corrects it to the version that is in this PR |
|
About the testing: I'd say it's okay if this functionality is not tested then. It is a nice add-on feature, but it does not change the functionality of the framework. |
|
Why is it working now 🤯 |
|
So adding/removing the |
|
The first time I encountered a Heisenbug in real life (Wikipedia):
|
|
Okay now we can see: So @JudithBernett was right, but still the local pre-commit always wants to change it to the current version |
|
So it seems to work now, unfortunately my local pre-commit isort still does not match the remote CI behavior, which makes the entire pre-commit process a bit annoying |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #348 +/- ##
==============================================
Coverage ? 81.63%
==============================================
Files ? 67
Lines ? 7138
Branches ? 0
==============================================
Hits ? 5827
Misses ? 1311
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hm maybe it's the version? I have 4.5.1; the latest one |
|
It's more about the isort version, I tried both 7.0.0 (latest) and 6.0.1 (used in the CI) |
Co-authored-by: Judith Bernett <38618495+JudithBernett@users.noreply.github.com>
434c5cf to
30af514
Compare
|
I played around with wandb a bit more, tested the implementation both with hyperparameter tuning on and off to ensure the logged metrics always make sense |
JudithBernett
left a comment
There was a problem hiding this comment.
looks great to me!! approved

This adds a first draft of what native weights and biases support could look like. Targets #6. Let's discuss if you guys like it so far or if it should be done differently.
Not sure if this can be tested properly, as it requires logging in to wandb in some way.
New feature
--wandb_project