Skip to content

Fix for invalid type annotations set in CsvFileHandler #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luketruter wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for invalid type annotations set in CsvFileHandler #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/CsvFileHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
*/
class CsvFileHandler
{
/** @var String */
/** @var string */
protected $filename;

/** @var Array */
/** @var array */
protected $records;

/** @var Boolean */
/** @var boolean */
protected $headerRow;

/** @var string */
Expand Down Expand Up @@ -166,7 +166,7 @@ public function setEscape($escape)

/**
* Get filename as specified in constructor
* @return String
* @return string
*/
public function getFilename()
{
Expand All @@ -175,7 +175,7 @@ public function getFilename()

/**
* Set filename for parsing
* @param String $filename
* @param string $filename
*/
protected function setFilename($filename)
{
Expand All @@ -184,7 +184,7 @@ protected function setFilename($filename)

/**
* Get array of RecordObject representing lines in the file
* @return Array
* @return array
*/
public function getRecords()
{
Expand All @@ -204,6 +204,7 @@ private function loadFilePointer(){
$fp = fopen($this->getFilename(), 'r');
$this->setFilePointer($fp);
}

/**
* @return null
*/
Expand Down