Skip to content

feat(external-link): adding target attribute #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(external-link): adding target attribute #22

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b60aa3
feat(external-link): adding target attributes
vettndr Nov 10, 2021
47ce190
fix(external-link): use Strict inequality
vettndr Nov 11, 2021
2ae9b9c
feat(external-link): check target
vettndr Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/templates/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,13 @@ export default ({ app: { router } }) => {

const addListeners = links => {
for (let i = 0; i < links.length; i++) {

const target = links[i].getAttribute('target')

if (links[i].hostname !== window.location.hostname && !target) {
links[i].target = '_blank';
}

// For improved security `rel="noopener"` will be added automatically if target is `_blank`
// https://github.com/mathiasbynens/rel-noopener/
if (target && target === '_blank') {
Expand Down