fix(install): cleanup download.tmp after extracting remote skill archives#330
Merged
yacosta738 merged 2 commits intomainfrom Apr 6, 2026
Merged
fix(install): cleanup download.tmp after extracting remote skill archives#330yacosta738 merged 2 commits intomainfrom
yacosta738 merged 2 commits intomainfrom
Conversation
…ives Prevents leftover temporary download files from being included in installed skill directories when fetching from remote URLs.
Contributor
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents leftover temporary download files from being included in installed skill directories when fetching from remote URLs.
This pull request makes a minor improvement to the skill installation process by ensuring that temporary download files are cleaned up after use.
src/skills/install.rs, after reading the downloaded file into memory, the code now removes the temporarydownload.tmpfile to prevent it from being included in the unpacked skill directory.