Open
Conversation
A table may have multiple foreign keys with cascaded deletes. The original logic would create a Compositions for each foreign key association, resulting in a single table being part of multipe Compositions, which is not permissable. Instead, if this condition applies, turn the associations into Associations.
djerius
changed the title
djerius
force-pushed
the
sql_translator_compositions
branch
from
33d50f9 to
1792396
Compare
The previous commit didn't properly handle the case where a table had multiple foreign key associations (with and without cascades) to one or more tables. The new logic implements the following rules: * a table which has fk cascades to more than one table must be an Association * a table which has multiple fk cascades to a single table (even if it has fk non-cascades) is a Composition. * a table with multiple fk cascades to a single ref table combines those cascades into a single Composition * a table with fk cascades and non-cascades to a single ref table splits the cascades into a Composition and the non-cascades to an Association Associations and Compositions are merged if possible.
djerius
force-pushed
the
sql_translator_compositions
branch
from
1792396 to
c5b5033
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly handle complex foreign key associations.
The new logic implements the following rules:
Association
has fk non-cascades) is a Composition.
those cascades into a single Composition
splits the cascades into a Composition and the non-cascades to an
Association