feat: add terminal support for terminal editors#22
Open
eugenesvk wants to merge 1 commit intodandavison:masterfrom
Open
feat: add terminal support for terminal editors#22eugenesvk wants to merge 1 commit intodandavison:masterfrom
eugenesvk wants to merge 1 commit intodandavison:masterfrom
Conversation
Owner
|
Interesting! |
- Get the terminal path from TERMINAL environment var - Wrap the editor command in a terminal command that is specific to that terminal (currently only WezTerm) but only for terminal editors - Add path parsing test - Update ReadMe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets the terminal path from
TERMINALenvironment var and wraps the editor command in a terminal command that is specific to that terminal (currently only WezTermwezterm cli spawn -- editor file:ln:col) but only for terminal editorsPath parsing test is added and ReadMe is updated
Not sure what to do with editors that can do both and have the same executable, maybe just remove the terminal not found error and let it spawn the same command as currently so that if the user wants to use the GUI one, he can unset the 'TERMINAL' var? Though that's clunky
So I think it's better to require different executable names and adjust our classes accordingly if needed
Closes #18