-
Notifications
You must be signed in to change notification settings - Fork 15
ci: update test configuration to vendorize dandiapi instance in tests #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4d20337 to
918af83
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #360 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 18 18
Lines 2377 2377
=======================================
Hits 2327 2327
Misses 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the GitHub Actions test workflow to support vendorized dandiapi instances in tests. It adds configuration for testing against the EMBER-DANDI instance in addition to the default configuration, enabling the test suite to validate compatibility with different DANDI Archive instances.
- Adds a
vendored_dandiapimatrix parameter with a default value - Includes two new matrix combinations for testing with the EMBER-DANDI instance (for both master and release versions)
- Sets environment variables for instance name, identifier, and DOI prefix when custom instances are used
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
918af83 to
9ec7784
Compare
|
Notes: As of now, only the integration tests against the release version of dandi-cli are failing. Once, the changes associated with dandi/dandi-cli#1752 are release, all tests should pass. |
|
@yarikoptic With the latest release of dandi-cli, all this one passes all tests, so this one is ready to merge. |
This PR is a duplicate of #355 since #355 was accidentally closed by mistake.
This PR updates test configuration in a GH workflow to vendorize the dandiapi instance used in tests. It builds on dandi/dandi-cli#1756, so it only works property after dandi/dandi-cli#1756 is merged.
This PR closes #350.
Notes: