Conversation
Add DRLG_L3 bugfix comment
Add enum for dlgresults
_asm.cpp and _render.cpp is still incorrectly encoded
Reference: https://github.com/diasurgical/scalpel/blob/master/psx/_dump_/3/_dump_c_src_/global_0.cpp#L2431 https://github.com/diasurgical/scalpel/blob/master/psx/_dump_/3/_dump_c_src_/diabpsx/source/drlg_l1.cpp#L542 https://github.com/diasurgical/scalpel/blob/master/psx/_dump_/3/_dump_c_src_/diabpsx/source/drlg_l2.cpp#L538 https://github.com/diasurgical/scalpel/blob/master/psx/_dump_/3/_dump_c_src_/diabpsx/source/drlg_l3.cpp#L499 https://github.com/diasurgical/scalpel/blob/master/psx/_dump_/3/_dump_c_src_/diabpsx/source/drlg_l4.cpp#L484
Correct types related to glSeedTbl
Based on @galaxyhaxz code in diasurgical/devilution#1294 (comment) Also, per suggestion of @sskras.
BUGFIX from original Diablo 1 code
Prior to this commit, several keyboard keys would not be translated, as detailed by the following debug message: DUMMY: translate_sdl_key : unknown key: name== sym=0x3D scan=46 mod=0x0 With this commit, all keys on regular US keyboards should be translated correctly.
Should we later notice that there are more keys not being translated, we can refer back to this commit for the remaining SDL key-codes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUGFIX from original Diablo 1 code