Fix insecure connections #1160
Open
Fix insecure connections #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every server configuration has its own setting that enables the use of insecure connections. This is disabled by default. Only verified https connections are allowed. Error messages with a note about the setting have been added. CVE-2018-1000664 Discussed in daneren2005#60
Replace subsonic.org demo server with navidrome.org demo server as the latter one uses a secure https connection. Enabling insecure connections by default to use the subsonic.org demo server would contradict the concept of "security by default".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every server configuration has its own setting that enables the use of
insecure connections. This is disabled by default. Only verified https
connections are allowed. Error messages with a note about the setting
have been added.
CVE-2018-1000664
Discussed in #60
The second commit replaces the http-only subsonic.org demo server with the Navidrome demo server.