upgrade to DSMR5.1 especially powerpeak support#30
Open
jellevervloessem wants to merge 68 commits intodaniel-jong:masterfrom
Open
upgrade to DSMR5.1 especially powerpeak support#30jellevervloessem wants to merge 68 commits intodaniel-jong:masterfrom
jellevervloessem wants to merge 68 commits intodaniel-jong:masterfrom
Conversation
feat: Add parsing for RETURNDELIVERY_*_TARIF
Some changes after reading improvements made by jhockx in his fork.
Thanks to @geerdkakes for the idea
Always use the default pin, changing it would make no sense.
Fix compatibility with latest SoftwareSerial and DSMR 4.2.2
Have these sensor show up in the energydashboard configuration
Changed device class and state class of some sensors so they can be integrated in energy management. This also gets rid of unknown unit of measurement errors.
Update p1_sensors.yaml
Fix daniel-jong#13 Removed unused reference to SoftwareSerial.h libary
change deprecated mqtt sensor yaml format
Update p1_sensors.yaml
Owner
|
Thanks for the PR, looks good! I think the following points are blocking
I just noticed that I have completely missed out on #21 that contains logic for both issues and should be able to merge that logic into these changes with not to much effort. Great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extension of the P1meter:
_Lost of commits are included because of issues with forks/branches and cleanup afterwards... _