Multiple suggestions#8
Open
qistoph wants to merge 5 commits intodaniel-jong:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for you work on the project. Some changes that I've made to suit my situation and preferences might be of interest to others. Not looking for another fork to be maintained, I'm hoping you'll consider merging these.
If there's anything that you'd like to see changed in the PR, I'd be happy to consider and discuss.
Commit messages should speak for themselves, though here's some of my rationale and considerations.
Nicer format incoming messages
New
Old
Start reading immediately after boot
Instead of waiting
UPDATE_INTERVALstart reading the P1 data immediately after boot. This is especially handy while testing.Move println next to action
Easy to understand, non-functional change to make the next one more easy to understand in the diff.
Make RX inversion configurable
My hardware was already built based on other projects online and uses a transistor to invert the serial signal. This change accommodates for such devices, while keeping the default unchanged.
Set hostname for DHCP requests
Setting the host name on
WiFiincludes it in DHCP requests enabling dynamic DNS updates.