feat(auth): Enable default values for params#36
Open
mgagliardo91 wants to merge 1 commit intodanielgtaylor:masterfrom
Open
feat(auth): Enable default values for params#36mgagliardo91 wants to merge 1 commit intodanielgtaylor:masterfrom
mgagliardo91 wants to merge 1 commit intodanielgtaylor:masterfrom
Conversation
| Keys []string | ||
| Params []string | ||
| Scopes []string | ||
| DefaultValues map[string]string |
Owner
There was a problem hiding this comment.
Does this need to get initialized somewhere? If we rely on it to happen in someone's main then what happens if they forget?
Owner
|
@mgagliardo91 also consider checking out https://rest.sh/ (https://github.com/danielgtaylor/restish) I've been thinking of suggesting an OpenAPI extension to auto-configure parts of the auth there. If you don't explicitly need code generation it might be a good option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hopes to allow the ability for consumers to add default values for parameters that will be sent up alongside the oauth2 authorizationCode request. Currently, you can add parameters that must be filled out by the user input when setting up a profile, this change allows us to define default values as a way to encode query params such as
audienceclient_id params without needing the user to configure it themselves.