Add proxy support #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way it is possible to pass additional keyword arguments to requests such as proxies.
Author
|
Further discussion please be directed to @RedpointsBots, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Red Points we decided to use this package to scrape the google play store. However, we needed to be able to pass proxies to the request. To do so, I have added the possibility of adding keyword arguments to each of the end points in the package which, in turn, will be passed to the
send_requestmethod to be passed onto request.This change is 100% backwards compatible and adds more flexibility to the code so that requests can be fine-tuned further but the default parameters were left intact.