Skip to content

fix: Replace hardcoded 'Daniel' user references with generic terms #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neilsoult wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Replace hardcoded 'Daniel' user references with generic terms #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Packs/pai-agents-skill/src/agents/Architect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ curl -X POST http://localhost:8888/notify \
- Message should be your 🎯 COMPLETED line (8-16 words optimal)
- Must be grammatically correct and speakable
- Send BEFORE writing your response
- DO NOT SKIP - Daniel needs to hear you speak
- DO NOT SKIP - the user needs to hear you speak

---

Expand Down
2 changes: 1 addition & 1 deletion Packs/pai-agents-skill/src/agents/Artist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ curl -X POST http://localhost:8888/notify \
- Message should be your 🎯 COMPLETED line (8-16 words optimal)
- Must be grammatically correct and speakable
- Send BEFORE writing your response
- DO NOT SKIP - Daniel needs to hear you speak
- DO NOT SKIP - the user needs to hear you speak

---

Expand Down
2 changes: 1 addition & 1 deletion Packs/pai-agents-skill/src/agents/ClaudeResearcher.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ curl -X POST http://localhost:8888/notify \
- Message should be your 🎯 COMPLETED line (8-16 words optimal)
- Must be grammatically correct and speakable
- Send BEFORE writing your response
- DO NOT SKIP - Daniel needs to hear you speak
- DO NOT SKIP - the user needs to hear you speak

---

Expand Down
2 changes: 1 addition & 1 deletion Packs/pai-agents-skill/src/agents/CodexResearcher.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ curl -X POST http://localhost:8888/notify \
- Message should be your 🎯 COMPLETED line (8-16 words optimal)
- Must be grammatically correct and speakable
- Send BEFORE writing your response
- DO NOT SKIP - Daniel needs to hear you speak
- DO NOT SKIP - the user needs to hear you speak

---

Expand Down
2 changes: 1 addition & 1 deletion Packs/pai-agents-skill/src/agents/Designer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ curl -X POST http://localhost:8888/notify \
- Message should be your 🎯 COMPLETED line (8-16 words optimal)
- Must be grammatically correct and speakable
- Send BEFORE writing your response
- DO NOT SKIP - Daniel needs to hear you speak
- DO NOT SKIP - the user needs to hear you speak

---

Expand Down
4 changes: 2 additions & 2 deletions Packs/pai-agents-skill/src/agents/Engineer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ curl -X POST http://localhost:8888/notify \
- Message should be your 🎯 COMPLETED line (8-16 words optimal)
- Must be grammatically correct and speakable
- Send BEFORE writing your response
- DO NOT SKIP - Daniel needs to hear you speak
- DO NOT SKIP - the user needs to hear you speak

---

Expand Down Expand Up @@ -181,7 +181,7 @@ curl -X POST http://localhost:8888/notify \
1. VERIFY dev server is running
2. CONFIRM server responds
3. VISUALLY VERIFY page loads correctly
4. ONLY THEN tell Daniel it's ready
4. ONLY THEN tell the user it's ready

---

Expand Down
2 changes: 1 addition & 1 deletion Packs/pai-agents-skill/src/agents/GeminiResearcher.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ curl -X POST http://localhost:8888/notify \
- Message should be your 🎯 COMPLETED line (8-16 words optimal)
- Must be grammatically correct and speakable
- Send BEFORE writing your response
- DO NOT SKIP - Daniel needs to hear you speak
- DO NOT SKIP - the user needs to hear you speak

---

Expand Down
2 changes: 1 addition & 1 deletion Packs/pai-agents-skill/src/agents/GrokResearcher.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ curl -X POST http://localhost:8888/notify \
- Message should be your 🎯 COMPLETED line (8-16 words optimal)
- Must be grammatically correct and speakable
- Send BEFORE writing your response
- DO NOT SKIP - Daniel needs to hear you speak
- DO NOT SKIP - the user needs to hear you speak

---

Expand Down
2 changes: 1 addition & 1 deletion Packs/pai-agents-skill/src/agents/Intern.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ curl -X POST http://localhost:8888/notify \
- Your voice_id is: `d3MFdIuCfbAIwiu7jC4a` (Intern voice)
- The message should be your COMPLETED line content
- Send this BEFORE writing your response
- DO NOT SKIP THIS - Daniel needs to HEAR you speak
- DO NOT SKIP THIS - the user needs to HEAR you speak

## 🚨🚨🚨 MANDATORY OUTPUT REQUIREMENTS - NEVER SKIP 🚨🚨🚨

Expand Down
2 changes: 1 addition & 1 deletion Packs/pai-agents-skill/src/agents/Pentester.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ curl -X POST http://localhost:8888/notify \
- Your voice_id is: `xvHLFjaUEpx4BOf7EiDd` (Tybon's voice)
- The message should be your COMPLETED line content
- Send this BEFORE writing your response
- DO NOT SKIP THIS - Daniel needs to HEAR you speak
- DO NOT SKIP THIS - the user needs to HEAR you speak

### Final Output Format (MANDATORY - USE FOR EVERY SINGLE RESPONSE)
ALWAYS use this standardized output format with emojis and structured sections:
Expand Down
2 changes: 1 addition & 1 deletion Packs/pai-agents-skill/src/agents/QATester.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ curl -X POST http://localhost:8888/notify \
- Message should be your 🎯 COMPLETED line (8-16 words optimal)
- Must be grammatically correct and speakable
- Send BEFORE writing your response
- DO NOT SKIP - Daniel needs to hear you speak
- DO NOT SKIP - the user needs to hear you speak

---

Expand Down
8 changes: 4 additions & 4 deletions Releases/v2.5/.claude/hooks/RelationshipMemory.hook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
*
* OUTPUT:
* - Writes to: MEMORY/RELATIONSHIP/YYYY-MM/YYYY-MM-DD.md
* - May update: skills/PAI/USER/ABOUT_DANIEL.md (significant learnings)
* - May update: skills/PAI/USER/ABOUT_PRINCIPAL.md (significant learnings)
*
* RELATIONSHIP NOTE TYPES:
* - W (World): Objective facts about Daniel's situation
* - W (World): Objective facts about the principal's situation
* - B (Biographical): What happened this session (first-person DA)
* - O (Opinion): Preference/belief with confidence
*
Expand Down Expand Up @@ -130,7 +130,7 @@ function analyzeForRelationship(entries: TranscriptEntry[]): RelationshipNote[]

// Track what happened this session
let sessionSummary: string[] = [];
let danielPreferences: string[] = [];
let principalPreferences: string[] = [];
let frustrations: string[] = [];
let positives: string[] = [];

Expand All @@ -143,7 +143,7 @@ function analyzeForRelationship(entries: TranscriptEntry[]): RelationshipNote[]
if (patterns.preference.test(text)) {
// Extract preference (simplified - would benefit from LLM analysis)
const snippet = text.slice(0, 200);
danielPreferences.push(snippet);
principalPreferences.push(snippet);
}

if (patterns.frustration.test(text)) {
Expand Down
2 changes: 1 addition & 1 deletion Releases/v2.5/.claude/skills/PAI/Tools/RelationshipReflect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* ACTIONS:
* 1. Scan MEMORY/RELATIONSHIP/ for recent notes
* 2. Update OPINIONS.md confidence scores based on evidence
* 3. Update ABOUT_DANIEL.md patterns and preferences
* 3. Update ABOUT_PRINCIPAL.md patterns and preferences
* 4. Check for milestone achievements → OUR_STORY.md
* 5. Queue soul updates if significant patterns emerge
*
Expand Down