fix: Replace hardcoded 'Daniel' user references with generic terms#556
Open
neilsoult wants to merge 1 commit intodanielmiessler:mainfrom
Open
fix: Replace hardcoded 'Daniel' user references with generic terms#556neilsoult wants to merge 1 commit intodanielmiessler:mainfrom
neilsoult wants to merge 1 commit intodanielmiessler:mainfrom
Conversation
Changes user identity references from hardcoded "Daniel" to generic "the user" or "principal" terminology, allowing PAI to work correctly for all users regardless of their configured principal.name. Fixes danielmiessler#555 Files changed: - 11 agent definition files: Changed "Daniel needs to hear you speak" to "the user needs to hear you speak" - Engineer.md: Also changed "tell Daniel it's ready" to "tell the user" - RelationshipMemory.hook.ts: Renamed danielPreferences → principalPreferences, updated documentation references - RelationshipReflect.ts: Updated ABOUT_DANIEL.md → ABOUT_PRINCIPAL.md Note: Author attribution ("Author: Daniel Miessler") and voice name references ("Daniel" ElevenLabs voice) are intentionally unchanged as these are correct. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
Testing Evidence1. TypeScript Compilation ✅2. Variable Rename Verification ✅3. No Remaining Hardcoded User References ✅4. Files Changed Summary
All changes are text replacements only - no logic changes. |
|
Not sure, but it might be intended. E.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
danielPreferencesvariable toprincipalPreferencesABOUT_DANIEL.mdtoABOUT_PRINCIPAL.mdThis allows PAI to work correctly for all users regardless of their configured
principal.namein settings.json.Changes
Agent Files (11 files in
Packs/pai-agents-skill/src/agents/):Hook Files:
RelationshipMemory.hook.ts: Renamed variable and updated docsRelationshipReflect.ts: Updated file referenceWhat's NOT Changed
Test plan
Fixes #555
🤖 Generated with Claude Code