Skip to content

Pr 62#66

Merged
danielnovais-tech merged 4 commits intomainfrom
pr-62
Feb 10, 2026
Merged

Pr 62#66
danielnovais-tech merged 4 commits intomainfrom
pr-62

Conversation

@danielnovais-tech
Copy link
Copy Markdown
Owner

@danielnovais-tech danielnovais-tech commented Feb 10, 2026

Description

Impact

User Benefit

Business Value

Roadmap Alignment

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Test coverage improvement
  • Dependency update

Testing

  • I have run existing tests (pytest tests/ -v)
  • I have added new tests for my changes
  • All tests pass locally

Checklist

  • My code follows the PEP 8 style guidelines
  • I have added docstrings (Google-style) to new functions/classes
  • I have updated the documentation (README, API.md, etc.)
  • My changes generate no new warnings or errors
  • I have checked my code for potential security vulnerabilities
  • I have verified that my changes work as expected

Related Issues

Closes #

Screenshots (if applicable)

Additional Context

Copilot AI review requested due to automatic review settings February 10, 2026 00:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds README documentation to help users prepare CSV inputs for the Manual CSV Pipeline portion of the Rural Connectivity Mapper.

Changes:

  • Added a “CSV templates” section with a basic and a complete example CSV snippet.
  • Linked readers to the full Manual CSV Pipeline guide for more details.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
4,Porto Alegre,TIM,-30.0346,-51.2177,88.7,14.1,42.3,7.2,1.1,2026-01-15T12:00:00
5,Manaus,Viasat,-3.1190,-60.0217,75.3,9.8,68.2,15.7,2.5,2026-01-15T12:30:00
```

Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The templates include jitter and packet_loss as if they are first-class measurement metrics, but the Manual CSV pipeline currently only preserves these columns as string metadata (see src/sources/manual_csv.py where they are copied into measurement.metadata), and they are not part of the canonical MeasurementSchema. This is likely to mislead users into thinking those values will be validated/used in scoring/analysis; either clarify here that these fields are stored as metadata only for Manual CSV ingestion, or remove them from the Manual CSV templates / link to the upload_csv.py template docs instead.

Suggested change
Note: in the Manual CSV pipeline, the `jitter` and `packet_loss` columns are preserved as string metadata only and are **not** part of the canonical `MeasurementSchema` or used directly in scoring/analysis.

Copilot uses AI. Check for mistakes.
@danielnovais-tech danielnovais-tech merged commit 6832070 into main Feb 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants