fix: Apply push changes within push method execution#37
Merged
danielroe merged 1 commit intodanielroe:mainfrom Feb 27, 2025
Merged
fix: Apply push changes within push method execution#37danielroe merged 1 commit intodanielroe:mainfrom
danielroe merged 1 commit intodanielroe:mainfrom
Conversation
|
@danielroe in case it's unclear @grgbkr is on the zero team. |
Collaborator
|
I indeed did copy it from solid but I wasn't sure if it was really needed. Very nice to have it fixed 👌🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Push Change(s) must be consumed synchronously during the push method execution. If they are consumed later relationships can have incorrect values that conflict with other changes, resulting in a
node already existserror being thrown byapplyChanges.The change to have the Vue view queue
#pendingChanges: Change[]and only apply themonTransactionCommit5d43ae0 was probably based on a similar change in zero-solid rocicorp/mono#3608, however that change was incorrect and later fixed by rocicorp/mono#3701. The zero-solid fix still delays apply changes tillonTransactionCommit, but it "materialized" the changes relationships. This was important for performance with SolidJS as SolidJS does not batch DOM updates.It is my understanding that Vue automatically batches DOM updates, thus it is simplest and probably most performant to just apply push changes immediately when received.