Architecture from facts and checksum from release#90
Open
takomyr wants to merge 1 commit intodanielrolls:masterfrom
Open
Architecture from facts and checksum from release#90takomyr wants to merge 1 commit intodanielrolls:masterfrom
takomyr wants to merge 1 commit intodanielrolls:masterfrom
Conversation
Let Ansible to discover host architecture. * Allows supporting aarch64 using the same code. Download checksum from Nix release site. * Makes supporting multiple archictures easier.
danielrolls
requested changes
Sep 27, 2025
Owner
danielrolls
left a comment
danielrolls
left a comment
There was a problem hiding this comment.
Thanks for submitting this. It's great to have another contributor.
As discussed I want to keep the checksum with this code so that if the nixos.org server is comprised this tool will not download compromised binaries by default. I can see though, how many will want to use your contribution. If we can just put it behind a flag like I did for the remove_nix_directory functionality I think that will suffice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let Ansible discover host architecture.
Download checksum from Nix release site.