Skip to content

Update ShellifyTemplate.hs#21

Merged
danielrolls merged 4 commits intodanielrolls:masterfrom
coillteoir:patch-1
Feb 22, 2025
Merged

Update ShellifyTemplate.hs#21
danielrolls merged 4 commits intodanielrolls:masterfrom
coillteoir:patch-1

Conversation

@coillteoir
Copy link
Contributor

@coillteoir coillteoir commented Feb 12, 2025

Adding newlines to templates for the flake.nix and shell.nix files

  • added newlines to both src/FlakeTemplate.hs and
    src/ShellifyTemplate.hs templates.
  • updated test logic to not strip out newlines to ensure that generated
    templates are matching correct file output.

@coillteoir
Copy link
Contributor Author

Solving #20

@danielrolls
Copy link
Owner

If this works the tests will fail because the flake.nix and shell.nix expected results in the tests now need a trailing newline too. These expected results are under test/outputs/. You can easily run tests locally by running nix build --print-build-logs. If you have any issues please ask.

Thank you for raising this PR!

* added newlines to both src/FlakeTemplate.hs and
  src/ShellifyTemplate.hs templates.
* updated test logic to not strip out newlines to ensure that generated
  templates are matching correct file output.
@coillteoir
Copy link
Contributor Author

coillteoir commented Feb 18, 2025

PR should be ready now, let me know if theres any feedback you have.

Accidentally closed it, and reopened (forgot keyboard shortcut for commenting)

Thank you for maintaining this project,

@coillteoir coillteoir closed this Feb 18, 2025
@coillteoir coillteoir reopened this Feb 18, 2025
@coillteoir
Copy link
Contributor Author

You will need to re-approve the CI, apologies

@danielrolls
Copy link
Owner

That's much nicer than what I had before. Thanks for contributing!

@danielrolls danielrolls merged commit 74fd877 into danielrolls:master Feb 22, 2025
1 check passed
@coillteoir
Copy link
Contributor Author

That's much nicer than what I had before. Thanks for contributing!

This tool has been a great help, glad to make a small improvement!

@danielrolls
Copy link
Owner

@coillteoir, it's good to here the tool helps. I've heard very little about

  • who's using this tool?
  • where they found it?
  • how intuitive it is?
  • what works?
  • what doesn't?
  • etc.

If you can fine some time for another contribution, I'd love to simply get some answers to these questions .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants