Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to make flipper accessible. The following changes have been made:
Fixes #8
Note: I need to put the aria-label text for the flip to next item button in the schema, I wasn't sure where the best location for it would be. Happy to move after discussion
This has been tested by our QA team using the NVDA screen reader on Chrome, IE 11 & Firefox. There are a couple of niggles with Firefox, I'm not sure how severe these issues are in terms of accessibility, crucially all content can be read by the screen reader and the component can be completed.
Issue 1
On Chrome and IE11 the newly pushed item is read out in it's entirety and then the focus is left on the item title, so the user essentially hears the entire item, then they must navigate back through it in order to get to the button to flip to the next item.
On Firefox, the newly pushed item is read out in it's entirety but then the focus is left on the 'next item' button, so if the user wants to read the item again they have to navigate back up through it to get to the top and then back down it again to read it in order.
Issue 2
When navigating through cards in Firefox the focus remains on the 'Next' button. When a user attempts to navigate back over the newly flipped cards text fields, the body text is read before the instruction text on flippers that contain no images. (Note: you can still hear the instruction text when navigating back down)
-Title text is read, press arrowDown, body text is read press arrowDown, instruction text is read press arrowDown.
-Card flips
-Focus is on button, press arrowUp
-body text is read, press arrowDown
-Instruction text is read