Changed Feature: Use checkboxes for assigning the hotkey modifiers in the Settings Dialog to enable Win key modifier & catch registration errors #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 10, 2025 16:35
Also will catch and display errors when registering hotkeys VS appears to have subtly adjusted the position of controls
flmbray
changed the title
Owner
|
Hey @flmbray thanks this looks promising. I am currently traveling but will look at it in detail next week. Thanks, -dan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was no UI ability to set the Win key as part of the "Jump to Desktop" hotkeys. This PR adds that ability. To avoid complicating the list of combinations, the radio buttons are converted to checkboxes, one each for Ctrl, Alt, Shift, and Win. UI Feedback is provided to the user when they have selected to use this feature but do not have modifiers selected, as well as when the modifiers selected are not recommended (i.e. selecting just Shift or just Win). In addition, registration errors are caught and displayed. The configuration file format is unchanged.