libunwind fixes (compile fix, fix error condition/message) #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lekensteyn
changed the title
Lekensteyn
force-pushed
the
fix-libunwind
branch
from
3d4e2a5 to
41d05ab
Compare
Contributor
Author
Owner
|
Looks good. Can you rebase it? |
The '#endif' is position on a weird place which results in a compile warning (-Wimplicit-function). Fix this and print a diagnostic message on startup if a backtrace is requested but support is missing. Note: only affects builds where you manually disable HAVE_LIBUNWIND.
The length param of unw_get_proc_name already takes care of the terminator, so remove the subtraction. The manual describes that the error code is given by the negative, so fix the condition checking against UNW_ENOMEM (verified by shrinking the buffer). Finally, the error message confused me (as a user) as it seems to suggest something about the process name (rather than procedure). Mention the more applicable "frame" instead (longer alternative: "procedure name of frame").
Allow a different compiler to be specified and split the actual object compile to a different target. Add a Phony target to avoid breaking when a literal "all" or "clean" exist.
Useful during development.
Lekensteyn
force-pushed
the
fix-libunwind
branch
from
41d05ab to
26698ea
Compare
Contributor
Author
|
Rebased and resolves conflicts by renaming CFLAGS to FLAGS. |
danni
added a commit
that referenced
this pull request
Aug 11, 2015
libunwind fixes (compile fix, fix error condition/message)
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a compile warning when LIBUNWIND is disabled,
fixes a truncated backtrace and improve the error message.
Two latter commits are for development.