Skip to content

Fixed bug 1 element in POS #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed bug 1 element in POS #2

wants to merge 1 commit into from

Conversation

huankimtran
Copy link

Around line 280

condensedPOS = simplify(distributePOS(POS)) if len(POS) > 1 else POS
has a bug.
Bug here, POS and the return of simplify do not have the same structure, but got returned to condensedPOS

@huankimtran
Copy link
Author

DEBUG=false => won't print debug message
DEBUG=true => print debug messages.

@huankimtran
Copy link
Author

Nice work btw!

@dantemazza
Copy link
Owner

what was your test case? I made major changes today btw so there are a bunch of conflicts. before changes are made, I need to make sure its clear the purpose of POS is to cover the remaining, non-essential prime implicants, using Petrick's Method. It is possible for POS to be empty, assuming all prime implicants are essential (as in test_case3.txt)

@dantemazza
Copy link
Owner

Nevertheless, thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huankimtran @dantemazza