v2025.12.07

[withJihyuk]

💡 JIRA TICKET

📃 작업내용

• 2025.12.07 릴리즈

✅ PR 체크리스트

• 이 작업으로 인해 변경이 필요한 문서가 변경되었나요? (e.g. .env, 노션, README)
• 이 작업을 하고나서 공유해야할 팀원들에게 공유되었나요? (e.g. "API 개발 완료됐어요", "환경값 추가되었어요")
• 작업한 코드가 정상적으로 동작하나요?
• Merge 대상 브랜치가 올바른가요?
• PR과 관련 없는 작업이 있지는 않나요?

[gemini-code-assist]

Summary of Changes

Hello @withJihyuk, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant release, introducing advanced features for managing bookable spaces and refining the application's foundational infrastructure. The changes enable more granular control over space reservations, allowing for configurations like overlapping bookings and multiple concurrent bookings by a single user. Concurrently, the underlying database schema has undergone a substantial update to support these new features and improve consistency, alongside a strategic overhaul of environment-specific configurations to enhance development and deployment workflows.

Highlights

• Enhanced Space Booking Options: Introduced new allowOverlap and allowMultiSpaceBooking fields to SpaceRequest, SpaceResponse, and Space entities, providing more flexible configuration for space reservations.
• Database Schema Evolution: The User entity's table name has been explicitly set to users, and new columns for space booking options have been added to the Space table. A new Flyway migration script (V5__v20251207.sql) handles these schema changes, including dropping and recreating foreign key constraints.
• Refined Environment Configuration: Application configurations have been updated to use distinct Spring profiles for dev and stg. The dev profile now utilizes an H2 in-memory database with initial data loaded from data.sql, while Flyway is enabled for stg and default profiles for robust schema management.
• Expanded Discord Notification Coverage: Discord notifications are now active in both dev and stg environments, extending monitoring and alerts to the staging deployment.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

이번 PR은 2025.12.07 릴리즈를 위한 변경 사항을 포함하고 있습니다. 공간(Space)에 중복 예약 및 다중 공간 예약 허용 여부 설정 기능이 추가되었고, 이에 따라 DTO, 엔티티, 유즈케이스가 수정되었습니다. 또한, 개발 환경을 위한 H2 데이터베이스 설정 및 초기 데이터가 추가되었고, stg 프로필 설정이 업데이트되었습니다.

리뷰 결과, 몇 가지 중요한 수정이 필요한 사항을 발견했습니다. 특히 V5__v20251207.sql 마이그레이션 스크립트에서 데이터 유실을 유발할 수 있는 심각한 문제들이 확인되었습니다. 테이블 이름 변경 및 컬럼 수정 시 DROP 후 CREATE/ADD 하는 방식은 기존 데이터를 모두 삭제하므로, RENAME TABLE 및 MODIFY COLUMN을 사용해야 합니다. 또한, NOT NULL 컬럼 추가 시 기본값을 설정하지 않으면 마이그레이션이 실패할 수 있습니다.

application.yaml 파일에 개발용 JWT 시크릿 키가 하드코딩되어 있는 보안 문제도 발견되었습니다. 이 키들은 버전 관리에서 제외하고 환경 변수 등을 통해 주입하는 것이 안전합니다.

자세한 내용은 각 파일의 리뷰 코멘트를 참고해주세요.