Skip to content

fix: hidden btn close #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lisofffa wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: hidden btn close #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions libs/shared-components/src/mini-overlay/overlay-wrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,19 +348,20 @@ const OverlayWrapper: FC<IOverlayWrapperProps> = ({
<Title style={{ userSelect: 'none', margin: '0 auto' }} level={3}>
Sign in
</Title>

<Button
type="text"
style={{
marginLeft: 'auto',
position: 'absolute',
right: '8px',
top: '8px',
}}
onClick={onClose}
>
<CloseIcon />
</Button>
{loggedInAccountId && (
<Button
type="text"
style={{
marginLeft: 'auto',
position: 'absolute',
right: '8px',
top: '8px',
}}
onClick={onClose}
>
<CloseIcon />
</Button>
)}
</Space>

<Text
Expand Down
2 changes: 1 addition & 1 deletion libs/shared-components/src/notifications/notification-feed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ const NotificationFeed: FC<{
<Flex vertical>
<Space direction="horizontal">
<Text type="secondary" style={{ textTransform: 'uppercase' }}>
New ({newNotifications.length - 1})
New ({newNotifications.length})
Copy link
Member

@alsakhaev alsakhaev Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check case when length is 0

</Text>
{newNotifications.length ? (
<Button
Expand Down
Loading