Fix precision issue in Market convert function#26
Conversation
Removes an early return in `convert` that incorrectly assumed USDC always has 6 decimals on every chain. Now properly fetches the target token's decimals and scales accordingly before applying the denominator. Also removes the associated FIXME comment. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes a bug where the
Market.convertfunction failed to respect the target token's actual decimals when converting USD to USDC. It previously assumed an implicit 6 decimals for USDC, which caused issues on chains where USDC has 18 decimals (e.g. BSC). Now scales the fiat amount dynamically according totokens[toToken_].decimals.PR created automatically by Jules for task 6780913422003828537 started by @dappvibe