-
Notifications
You must be signed in to change notification settings - Fork 780
Adding pluggable secret store doc #3792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
|
@pravinpushkar - Can you also add examples for implementing the .NET and Go components for the secret store, like these?
Also if you check that this sample https://github.com/dapr/samples/tree/master/pluggable-components-dotnet-template still works for the v1.12 release and if so update the readme to say this is still valid for 1.12. That would be a huge bonus and benefit!! Thanks |
hhunter-ms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
msfussell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pravinpushkar - Can you look at my suggestions
We cannot mention the developments usings SDKs yet. The .Net and Go PR for dapr-sandbox repo are under development and I will rebase the PRs as soon as stable runtime version 1.12 gets released. Once these PRs are merged, I can revisit this part of the doc. Relevant PRs -
Samples works for 1.12. Just updated the Proto for state store and readme.md to be inline with latest enhancements. Relevant PR - dapr/samples#164 (This is ready for review/merge) |
|
@pravinpushkar - Really appreciate getting the sample in. Will do the SDK updates later. |
msfussell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Added Pluggable component secret store documentation.
Issue reference
closes #3783