Skip to content

Conversation

@pravinpushkar
Copy link
Contributor

@pravinpushkar pravinpushkar commented Oct 6, 2023

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Added Pluggable component secret store documentation.

Issue reference

closes #3783

Signed-off-by: Pravin Pushkar <ppushkar@microsoft.com>
@pravinpushkar pravinpushkar requested review from a team as code owners October 6, 2023 06:04
@msfussell
Copy link
Member

@pravinpushkar - Can you also add examples for implementing the .NET and Go components for the secret store, like these?

Also if you check that this sample https://github.com/dapr/samples/tree/master/pluggable-components-dotnet-template still works for the v1.12 release and if so update the readme to say this is still valid for 1.12. That would be a huge bonus and benefit!! Thanks

@mukundansundar mukundansundar linked an issue Oct 9, 2023 that may be closed by this pull request
Copy link
Contributor

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pravinpushkar - Can you look at my suggestions

@pravinpushkar
Copy link
Contributor Author

pravinpushkar commented Oct 10, 2023

@msfussell

@pravinpushkar - Can you also add examples for implementing the .NET and Go components for the secret store, like these?

We cannot mention the developments usings SDKs yet. The .Net and Go PR for dapr-sandbox repo are under development and I will rebase the PRs as soon as stable runtime version 1.12 gets released. Once these PRs are merged, I can revisit this part of the doc.

Relevant PRs -

  1. feat/secretstore dapr-sandbox/components-dotnet-sdk#42
  2. [WIP]Local env secret store implementation dapr-sandbox/components-go-sdk#28

Also if you check that this sample https://github.com/dapr/samples/tree/master/pluggable-components-dotnet-template still works for the v1.12 release and if so update the readme to say this is still valid for 1.12. That would be a huge bonus and benefit!! Thanks

Samples works for 1.12. Just updated the Proto for state store and readme.md to be inline with latest enhancements.

Relevant PR - dapr/samples#164 (This is ready for review/merge)

@msfussell
Copy link
Member

@pravinpushkar - Really appreciate getting the sample in. Will do the SDK updates later.
Thanks

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[1.12] Secrets store support for pluggable components

5 participants